Skip to content

🐛Storage: Celery issues with validation #7427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2025
Merged

🐛Storage: Celery issues with validation #7427

merged 5 commits into from
Mar 26, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 26, 2025 •
edited
Loading

What do these changes do?

NOTE: this will be forcibly pushed

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Mar 26, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 26, 2025
@sanderegg sanderegg self-assigned this Mar 26, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner March 26, 2025 07:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pcrespov
pcrespov approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (cdff4c5) to head (0727aab).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cdff4c5) and HEAD (0727aab). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (cdff4c5) HEAD (0727aab)
unittests 31 25
integrationtests 6 3
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7427      +/-   ##
==========================================
- Coverage   87.34%   79.51%   -7.84%     
==========================================
  Files        1714     1608     -106     
  Lines       66587    61660    -4927     
  Branches     1131     1131              
==========================================
- Hits        58162    49028    -9134     
- Misses       8103    12325    +4222     
+ Partials      322      307      -15
Flag Coverage Δ
integrationtests 58.97% <ø> (-6.17%) ⬇️
unittests 79.15% <100.00%> (-7.37%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.24% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.05% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 73.02% <100.00%> (+<0.01%) ⬆️
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 65.72% <ø> (-19.74%) ⬇️
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.70% <ø> (+0.09%) ⬆️
director_v2 85.53% <ø> (-5.78%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.23% <ø> (+0.10%) ⬆️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 65.60% <ø> (-20.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdff4c5...0727aab. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit 96791e7 into ITISFoundation:master Mar 26, 2025
76 of 90 checks passed
@sanderegg sanderegg deleted the storage/various-fixes-rabbitmq branch March 26, 2025 07:48
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@sanderegg @mrnicegyu11
🐛Storage: Celery issues with validation (ITISFoundation#7427)
c22a9ea
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

a:storage issue related to storage service

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

3 participants

@sanderegg @GitHK @pcrespov